thanawat158 / mixare

Automatically exported from code.google.com/p/mixare
0 stars 0 forks source link

search and intents #134

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
currently devV0.9.3 is having problems with searchs.

What steps will reproduce the problem?
1.  MixMap or MixListView -> search anything -> breaks
2- MixView deletes markers without starting an intent.

due to search method that relaunch the same activity with different markers, 
meaning it stores search result markers over the original one, and launch the 
same caller activity to render the result markers.

This approach doesn't work with android Activity recommended life-cycle, 
"startActivityForResults() & onActivityResult()" 
and provide overhead and extra copies of markers. "originalMarkerLists, 
MarkerList, DataView.getMarkerList()"
which all store the same thing!

This also bring an old activity that is not much used "datasourceList" which 
started to be the activity that handles datasources and viewing the search 
results.
Now it's barely used "AS an ACTIVITY".

I'm suggesting sending search queries to MixListView as intent and display them 
their as datasourceList would do. and remove datasourceList class.

The proposed changed will clear out replicate "doMixSearch()" methods, and sets 
MixListView as the search viewer.

discovered while in "CodeEnhancement" Milestone:
https://github.com/DevBinnooh/mixare/issues/milestones?with_issues=no 

Original issue reported on code.google.com by DevBinn...@gmail.com on 13 Jun 2012 at 1:35

GoogleCodeExporter commented 8 years ago
Fixed 
https://github.com/mixare/mixare/pull/50

Original comment by DevBinn...@gmail.com on 13 Jun 2012 at 11:18

GoogleCodeExporter commented 8 years ago
closing since the relevant code was merged and search works now.

Thanks a lot!

Original comment by daniele.gobbetti on 20 Jun 2012 at 3:40