thane98 / paragon

Toolkit for editing various FE games.
GNU General Public License v3.0
54 stars 17 forks source link

Functionality for Locking Skills Missing [FE10] #85

Closed Dulnado closed 2 years ago

Dulnado commented 2 years ago

Currently, there isn't a way to change a specific part of a skill's data that's required to modify who can equip/unequip a skill. Being able to modify this is required to lock skills entirely or allow specific units/classes to equip them.

For example, for 'Wrath' the bytes for this would be 04 02 00 00 (starts at 33 out of 44 bytes total) and currently you're unable to edit this in Paragon. Removing the skills 'Unlock Item' and conditions may show the locked icon in-game, but you'd still be able to remove it (and if it's a class skill, would crash the game as far as I'm aware).

A field should therefore be added for it.

thane98 commented 2 years ago

Isn't this covered by the "Learn Conditions" sections on the UI? In the skill module, Paragon has these fields for bytes 33-36:

0x33: condition_table_entry_count (1 byte)
0x34: condition_table_2_entry_count (1 byte)
0x35: unknown_2 (2 bytes)

followed by the first and second condition table.

This seems to line up with your example for Wrath. Four entries in the first table, two entries in the second table, and unknown_2 is zeroed out. This is what I see in the UI: Capture

Maybe this needs to be renamed from "Learn Conditions" to "Equip Conditions"?

Dulnado commented 2 years ago

I've now figured out why this happened. If you click the 'Delete' button to remove all conditions, then the 04 02 00 00 does not get cleared (only the 8 bytes after that), resulting in this:

image

Instead, when testing out another skill I deleted each condition separately (next to 'Add') without selecting the aforementioned button at all. That worked as intended.

So it's possibly just a problem with that first option in particular?

thane98 commented 2 years ago

Yeah I think I see what happened here. I'll hide the delete buttons for these tables since there's no reason to use it vs. deleting individual entries.