thanhduc2000 / pe

0 stars 0 forks source link

Abstract class diagram #13

Open thanhduc2000 opened 4 years ago

thanhduc2000 commented 4 years ago

image.png

nus-pe-bot commented 4 years ago

Team's Response

Thank you for your response, this is a valid issue, but the team felt that the severity level was too high, because it does not cause any major implications to the design of the program. If the variables above were initialised with package private, it would still be valid.

'~' is not an invalid notation as it means package private, however we should have used a '-' for private instead as we got confused by the two.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]