thanhduc2000 / pe

0 stars 0 forks source link

Not following UG's guideline #6

Open thanhduc2000 opened 4 years ago

thanhduc2000 commented 4 years ago

image.png

It's mentioned in the UG that 24:00 will be parsed to 23:59. However, in this message, it still print out 0:00

nus-pe-bot commented 4 years ago

Team's Response

Thank you for indicating such user case:

In the UG, we specify that we will parse 24:00 to 23:59 becasue java will parse 24:00 to 00:00 automatically. However, sth like 23:00-24:00 should be valid. However, if we input 24:00 such as example here 24:00-23:59 --> it changes to 00:00-23:59 which is valid becasue 00:00 means the beginning of next day.

However, thank you for that. May be we should put it to UG.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: Please refer to this image to check what a functionality bug is

image.png

This can only be a documentation bug when your team's program can handle with this case correctly but not stated in the Documentation. However, the bug is not documented. Therefore, this is considered as a functionality bug. Moreover, the program is accepting an invalid time range, which makes the case even worse.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Since the program accepted invalid time range, the severity should be set as medium.

image.png

image.png