search

thanhhe / omaha

Automatically exported from code.google.com/p/omaha
0 stars 0 forks source link

CrashReports folder should be created whenever it is required #24

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
OS: XP

-Install Google chrome from Omaha (google.com/chrome)
-Delete CrashReports folder from C:\Documents and Settings\user\Local 
Settings\Application Data\Google
-Launch Chrome and navigate to about:crash

Expected:
CrashReports folder should be created.

Issue:
Folder is not created. If user navigates to about:crash, the tab hangs for 2 or 
3 mins, then user shows up with sad tab. Before sad tab is shown, if user tries 
to move the tab, then browser window crashes some times.

PS: If user deletes the CrashReports folder then installs Chrome from Omaha, 
then the CrashReports is created.

Original issue reported on code.google.com by venkatar...@chromium.org on 19 Aug 2010 at 8:37

GoogleCodeExporter commented 8 years ago 
Is Chrome accessing this directory via Omaha or directly via file APIs? If it's 
the latter, then this seems like a Chrome bug.

I think it would be better if Chrome could handle the absence of the directory 
since Omaha shouldn't need to create the CrashReports directory until a crash 
occurs and crash reporting is enabled.

Original comment by ddor...@google.com on 23 Aug 2010 at 5:48

GoogleCodeExporter commented 8 years ago 
Is Chrome accessing this directory via Omaha - YES.

Original comment by venkatar...@google.com on 23 Aug 2010 at 7:10

GoogleCodeExporter commented 8 years ago 
Can you give us more details on the Omaha API it's using?

Is there a separate bug on the browser window crashing? Chrome should be able 
to withstand problems in the tab/API/non-existing directory.

Original comment by ddor...@google.com on 23 Aug 2010 at 7:37

GoogleCodeExporter commented 8 years ago 
I'm not using any API's directly.
Please follow clear repro steps in the original bug report. Let me know, if you 
are not able to reproduce it !!!

Original comment by venkatar...@google.com on 23 Aug 2010 at 8:22

GoogleCodeExporter commented 8 years ago 
This is an issue with Breakpad, not Omaha.

When the Omaha crash handler starts up, we create the directory and pass its 
path to Breakpad.  If that directory has been deleted, Breakpad needs to either 
detect that and report an error to Omaha, or create it itself.  As it is, 
Breakpad simply reports a process exit without ever hitting our dump callback.

I'd suggest adding your report to the existing bug here:

http://code.google.com/p/google-breakpad/issues/detail?id=298

Original comment by ryanmyers@google.com on 16 Mar 2012 at 11:44