search

thanhlong203 / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

goog.dom.getDocumentScroll doesn't work on iOS 4 #235

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
On iOS 4 (tested on 4.1), goog.dom.getDocumentScroll always returns 0. It 
appears that this is due to a bug in mobile Safari. It likely hasn't been 
noticed because there's no unit test for that method.

I'm attaching a patch that fixes getDocumentScroll and adds a unit test.

Original issue reported on code.google.com by amat...@gmail.com on 24 Nov 2010 at 12:02

Attachments:

GoogleCodeExporter commented 8 years ago 
I screwed up the patch b/c I created it off my forked repo. I created a code 
review instead: http://codereview.appspot.com/3301041/

Original comment by amat...@gmail.com on 24 Nov 2010 at 6:00

GoogleCodeExporter commented 8 years ago 
The base URL was messed up in the code review due to the issue described here: 
<http://groups.google.com/group/closure-library-discuss/browse_thread/thread/eeb
6d6a9d1c9c342/b1b15fb673f39b9d>. I just now edited the review and fixed the 
base so the change can be more easily reviewed.

Original comment by amat...@gmail.com on 13 Dec 2010 at 10:47

GoogleCodeExporter commented 8 years ago 
Fixed in r724

Original comment by Nicholas.J.Santos on 25 Feb 2011 at 5:39