thanhlong203 / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

closurebuilder.py does not accept multiple compiler_flags #280

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Perhaps this is just a usage issue (if so the docs should be updated to 
clarify), but it seems like closurebuilder.py will not let you pass multiple 
compiler_flags

$ /home/bmccann/src/closure/closure-library/closure/bin/build/closurebuilder.py 
\
>   --root=/home/bmccann/src/closure/closure-library \
>   --root=js \
>   --namespace=bm \
>   --output_mode=compiled --compiler_flags="--third_party 
--compilation_level=SIMPLE_OPTIMIZATIONS" 
--compiler_jar=/home/bmccann/src/closure/compiler.jar \
>   > js/compiled.js
/home/bmccann/src/closure/closure-library/closure/bin/build/closurebuilder.py: 
Scanning paths...
/home/bmccann/src/closure/closure-library/closure/bin/build/closurebuilder.py: 
686 sources scanned.
/home/bmccann/src/closure/closure-library/closure/bin/build/closurebuilder.py: 
Building dependency tree..
/home/bmccann/src/closure/closure-library/closure/bin/build/closurebuilder.py: 
Compiling with the following command: java -jar 
/home/bmccann/src/closure/compiler.jar --js 
/home/bmccann/src/closure/closure-library/closure/goog/base.js --js 
/home/bmccann/src/closure/closure-library/closure/goog/debug/error.js --js 
/home/bmccann/src/closure/closure-library/closure/goog/string/string.js --js 
/home/bmccann/src/closure/closure-library/closure/goog/asserts/asserts.js --js 
/home/bmccann/src/closure/closure-library/closure/goog/array/array.js --js 
/home/bmccann/src/closure/closure-library/closure/goog/dom/classes.js --js 
/home/bmccann/src/closure/closure-library/closure/goog/object/object.js --js 
/home/bmccann/src/closure/closure-library/closure/goog/dom/tagname.js --js 
/home/bmccann/src/closure/closure-library/closure/goog/useragent/useragent.js 
--js /home/bmccann/src/closure/closure-library/closure/goog/math/size.js --js 
/home/bmccann/src/closure/closure-library/closure/goog/dom/browserfeature.js 
--js /home/bmccann/src/closure/closure-library/closure/goog/math/coordinate.js 
--js /home/bmccann/src/closure/closure-library/closure/goog/dom/dom.js --js 
js/hello.js --third_party --compilation_level=SIMPLE_OPTIMIZATIONS
"--third_party --compilation_level=SIMPLE_OPTIMIZATIONS" is not a valid option

Original issue reported on code.google.com by bmcc...@google.com on 27 Feb 2011 at 6:46

GoogleCodeExporter commented 8 years ago
Use instead: --compiler_flags="--third_party" 
--compiler_flags="--compilation_level" --compiler_flags="SIMPLE_OPTIMIZATION"

Original comment by version...@gmail.com on 1 Mar 2011 at 10:59

GoogleCodeExporter commented 8 years ago
Ah, ok.  I wouldn't have guessed that.  The docs should be updated to make that 
clear.  Thanks for the help.

Original comment by bmcc...@google.com on 1 Mar 2011 at 4:21

GoogleCodeExporter commented 8 years ago
I just realized this is related to issue 164.

Original comment by amat...@gmail.com on 4 Mar 2011 at 4:13

GoogleCodeExporter commented 8 years ago

Original comment by pall...@google.com on 16 Nov 2011 at 4:29