search

thanhlong203 / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

Minor improvements to goog.ui.ComboBox #296

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Just a few small changes.

Use goog.dom.TagName where appropriate and add a CSS class to the input created 
by goog.ui.ComboBox

http://codereview.appspot.com/4309041/

Original issue reported on code.google.com by hong.rich on 22 Mar 2011 at 4:04

GoogleCodeExporter commented 8 years ago 
IMO this change doesn't give real improvements.

I've never understood the point of goog.dom.TagName, it doesn't give any 
abstraction.
As the combobox is tightly coupled with the input element, I don't see the 
point of introducing the goog-combobox-input class name either.

Original comment by pall...@google.com on 27 Mar 2011 at 7:16

GoogleCodeExporter commented 8 years ago 
Adding a class name to the input is a performance improvement. 
http://code.google.com/speed/page-speed/docs/rendering.html

I don't care much about the goog.dom.TagName, I just happen to touch that line 
of code.

Original comment by hong.rich on 27 Mar 2011 at 7:33

GoogleCodeExporter commented 8 years ago

Original comment by nn...@google.com on 27 Apr 2012 at 10:57

GoogleCodeExporter commented 8 years ago 
CLA not signed.  See contributors page.

In any case, closing for now, as the performance gain is minor.

Original comment by nn...@google.com on 15 May 2012 at 10:58