When a player doesn't own any country, they should be excluded from issue order - Githubissues

thanhpd / soen6441

Concordia University - SOEN 6441 - Advanced Programming Practices

MIT License

1 stars 1 forks source link

When a player doesn't own any country, they should be excluded from issue order #318

Closed thanhpd closed 10 months ago

thanhpd commented 10 months ago

Reproduction:

Download and extract default4.dat archives.zip to src\main\resources\archives
Start the program, choose singleplayer > loadgame default4. The game should be loaded successfully. The orders are already loaded for player3 to conquer country2 from player1. (deploy country1 country2 9)
Type commit to execute orders

Expected result:

Orders are executed, player1 should be removed from the game since they lost

Actual result:

Orders are executed, the game keeps waiting for player1 to issue order but they can't since they doesn't own any country.

YajingLiu2357 commented 10 months ago

Fix bug in commit 043cb98dbe59600501ca71715886875c7fa0e5fe