thankgodr / javascriptCapstoneProject

MIT License
0 stars 1 forks source link

Microverse Project: Set up your Kanban board #21

Closed jose-Abel closed 2 years ago

jose-Abel commented 2 years ago

Hello, This is the issue opened for Review of the Microverse Project: Set up your Kanban board.

Link for our Github repository: https://github.com/thankgodr/javascriptCapstoneProject On our team there's 2 people, ThankGod Richard and Jose Abel.

Cheers.

carlos-ssh commented 2 years ago

Hi @jose-Abel ,

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Required Changes ♻️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.

SpaYco commented 2 years ago

Hello 👋,

This is an additional review as a result of the second opinion request.

You're right, since your group consists of 2 people, Student C cards wouldn't have anyone assigned to them.

As this was the only reason that your project was not approved it will be approved as soon as possible. Please ask for another review in your Dashboard and the next Code Reviewer will mark it as approve right away :)

Keep rocking 🚀!

EricMbouwe commented 2 years ago

Hi @jose-Abel and @thankgodr,

Status: Approved ✔️

Excellent job on this project. Keep it up 👏 Your project is complete! There is nothing else to say other than... it's time to merge it 💪 Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.