search

thanos-community / obslytics

Tools and Services allowing seamless usage of Observability data from Prometheus, Thanos, Cortex, M3DB, Loki and more!
Apache License 2.0
30 stars 8 forks source link

Implement the Remoteread Package #10

Closed 4n4nd closed 3 years ago

4n4nd commented 3 years ago

Extended the input.go package for the remote read API

These changes are based on the input.go in #3

Addressing #6

4n4nd commented 3 years ago

This package will need to be updated once the remote read streaming support is added to the prometheus client

bwplotka commented 3 years ago

As per unit test, I would quickly use Thanos helper for running Prometheus. See: https://github.com/thanos-io/thanos/blob/65049b16e1f9fcee8003f0c2e6fe3e80998bf22a/pkg/promclient/promclient_e2e_test.go#L81

4n4nd commented 3 years ago

@bwplotka should be ready for review now

4n4nd commented 3 years ago

@bwplotka it seems the CI is failing because the "github.com/prometheus/prometheus/storage/remote" package is not the latest (pkg/input/promread/promread.go:84:17: undefined: remote.NewReadClient), how can I update the package version in the repo?

bwplotka commented 3 years ago

As talked offline, I can try upgrading this for us. I have to do it anyway for Thanos new release (: