thanos-community / thanos-operator

WIP: Operator to manage Thanos installation
Apache License 2.0
22 stars 3 forks source link

ctrl: Refactor options conversions for readability #108

Closed philipgough closed 3 weeks ago

philipgough commented 3 weeks ago

Prior to this change, there was a likely possibility that if you created two separate CRs for controllers, there would be issues with the naming

Say ThanosReceive: xyz and ThanosStore: xyz would both try to create statefulsets of the same name. This change takes care of that by adding a prefix for the names and making them discoverable from other packages (ie tests).

We will likely still want to add validation to the names but at least it is clear where and what is happening now.

Receive isnt included here because it needs its own refactor.