thanos-community / thanos-operator

WIP: Operator to manage Thanos installation
Apache License 2.0
22 stars 3 forks source link

Cache configuration should be stored in Secrets #119

Closed philipgough closed 1 week ago

philipgough commented 2 weeks ago

For store a qfe, such as https://github.com/thanos-community/thanos-operator/blob/main/api/v1alpha1/thanosstore_types.go#L46-L51 the cache config is a selector to a configmap.

However as per https://thanos.io/tip/components/store.md/#redis-index-cache some cache implementations hold reference to db user/pass etc so storing them in a Secret is likely a better alternative, since orgs may lock down access to these Secrets via rbac