search

thanos-io / kube-thanos

Kubernetes specific configuration for deploying Thanos.
Apache License 2.0
521 stars 176 forks source link

Add more store flags #187

Closed craigfurman closed 3 years ago

craigfurman commented 3 years ago

Changes

Add more flags to thanos-store: max-time, min-time, and store.grpc.series-sample-limit.

Implements https://github.com/thanos-io/kube-thanos/issues/175

Verification

make generate validate, and I've experimented with it in a consumer repository that I use to manage thanos.

kakkoyun commented 3 years ago

@craigfurman Probably needs a rebase.

craigfurman commented 3 years ago

@kakkoyun thanks, rebased :+1:

@metalmatze sorry for the prodding, but have you had a chance to read my reply on one of the threads above? https://github.com/thanos-io/kube-thanos/pull/187#discussion_r555236740

If you'd still prefer to remove that function and do the null checks inline, I can do that, but wanted to justify my initial decision first :slightly_smiling_face.

craigfurman commented 3 years ago

rebased again

craigfurman commented 3 years ago

In the time since I opened this, I see that minTime / maxTime have been implemented. I'll close this.

kakkoyun commented 3 years ago

@craigfurman Sorry that we've missed this 🙈 Thanks a million again for your contributions.

craigfurman commented 3 years ago

no worries! it happens.