jsonnet/kube-thanos: Ignore individual ServiceMonitor with catch-all - Githubissues

thanos-io / kube-thanos

Kubernetes specific configuration for deploying Thanos.

Apache License 2.0

520 stars 177 forks source link

jsonnet/kube-thanos: Ignore individual ServiceMonitor with catch-all #204

Closed brancz closed 3 years ago

brancz commented 3 years ago

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user. (this fixes a bug in an unreleased change)

Changes

Prevent rendering individual ServiceMonitors when there is already a ServiceMonitor selecting all receive pods.

Verification

Previously got out-of-order and duplicate sample errors in Prometheus because the same target was discovered twice, now not anymore.

@kakkoyun @metalmatze