search

thanos-io / kube-thanos

Kubernetes specific configuration for deploying Thanos.
Apache License 2.0
520 stars 177 forks source link

Support full stack in kustomization.yaml #215

Open cten opened 3 years ago

cten commented 3 years ago

The current kustomization.yaml file doesn't support all the components of the Thanos stack. Can it be updated to use the manifests from the examples/all-manifests folder or can we add a kustomization.yaml file to the that folder? Would be happy to create a PR if it can be decided where the best location is. Thanks

metalmatze commented 3 years ago

The manifests folder is supposed to be a small but functional example of a Thanos stack that can be applied and should work. The files in examples/all/manifests is literally enabling all available configuration options to be able to better track the output of our jsonnet stack over time. I'm certain that the outputs from that folder will not work - and won't even make sense to be applied as they are.

We can for sure update the kustomization.yaml to support everything from manifests/ :+1:

cten commented 3 years ago

Can you tell me if the file names in examples/all/manifests change often? Do the resource names declared in the manifests change often? Final question: can you give guidance on the different sharding options available in the jsonnet config (1 Statefulset or 3 almost identical Statefulsets)?