search

thanos-io / kube-thanos

Kubernetes specific configuration for deploying Thanos.
Apache License 2.0
520 stars 177 forks source link

Compact statefulset has a non-headless service as it's serviceName #243

Closed stevehipwell closed 2 years ago

stevehipwell commented 3 years ago

I'm not sure if this is a problem, but the compact statefulset doesn't have the corresponding headless service to the value set in serviceName like the other statefulsets.

yeya24 commented 3 years ago

It makes sense. Are you willing to open a pr to fix it? Thanks!

stevehipwell commented 3 years ago

@yeya24 I'll have a go, I'm not really a jsonnet expert and I was working from the example manifests to create a Thanos Helm chart when I spotted this.

stevehipwell commented 3 years ago

@yeya24 does compact need a non-headless service as there should only ever be one pod?

yeya24 commented 3 years ago

@yeya24 does compact need a non-headless service as there should only ever be one pod?

Good point! Then non-headless service seems ok in this case.