thanos-io / kube-thanos

Kubernetes specific configuration for deploying Thanos.
Apache License 2.0
520 stars 177 forks source link

Add extra env vars to all components deployed with kube-thanos #251

Closed mwasilew2 closed 2 years ago

mwasilew2 commented 2 years ago

closes: https://github.com/thanos-io/kube-thanos/issues/246

Changes

Verification

to test this change I edited the default values for a few components (not all!) and added the following:


          {
            name: 'JAEGER_DISABLED',
            value: 'false',
          },
          {
            name: 'JAEGER_SAMPLER_TYPE',
            value: 'probabilistic',
          },
          {
            name: 'JAEGER_SAMPLER_PARAM',
            value: '0.01',
          },
          {
            name: 'JAEGER_AGENT_HOST',
            valueFrom: {
              fieldRef: {
                fieldPath: 'status.hostIP',
              },
            },
          },

I then run make all which includes automated verification of validity of generated k8s yaml files. I also eye-balled the generated files in ./examples and ./manifests to see if they looked as expected