Closed achede22 closed 2 years ago
@achede22 please sign your commit and then we can merge this :)
Hint: git commit amend --signoff
@achede22 please sign the DCO and we can merge :)
Done!, the DCO has been signed.
Please check
On Wed, Mar 30, 2022 at 6:21 AM Lucas Servén Marín @.***> wrote:
@achede22 https://github.com/achede22 please sign the DCO and we can merge :)
— Reply to this email directly, view it on GitHub https://github.com/thanos-io/kube-thanos/pull/268#issuecomment-1082832016, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHDBS2AFB2TC2BBE4MOBRR3VCQMI3ANCNFSM5RSXEAQA . You are receiving this because you were mentioned.Message ID: @.***>
Perfect! 👍
Because we embed some files for ease in our README.md and we generate that, could you be so kind and run make README.md
to update the README with your changes? Thanks!
Perfect! +1 Because we embed some files for ease in our README.md and we generate that, could you be so kind and run
make README.md
to update the README with your changes? Thanks!
done!
make README.md done! Thanks
On Mon, Apr 4, 2022 at 6:50 AM Matthias Loibl @.***> wrote:
Perfect! 👍 Because we embed some files for ease in our README.md and we generate that, could you be so kind and run make README.md to update the README with your changes? Thanks!
— Reply to this email directly, view it on GitHub https://github.com/thanos-io/kube-thanos/pull/268#issuecomment-1087345556, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHDBS2GRVZUJRAQA2TPGCI3VDK3PPANCNFSM5RSXEAQA . You are receiving this because you were mentioned.Message ID: @.***>
Hi @achede22 it looks like one of more of your commits doesn't have the DCO signed. Once you sign we can merge :) it might be easiest if you squash your commits, as then you'll only need to sign once.
Let me do it again with just one commit, Thanks
add "mkdir -p" so it can create parent folders avoid the following error:
Changes
Verification