thanos-io / kube-thanos

Kubernetes specific configuration for deploying Thanos.
Apache License 2.0
520 stars 177 forks source link

add "mkdir -p" so it can create parent folders #268

Closed achede22 closed 2 years ago

achede22 commented 2 years ago

add "mkdir -p" so it can create parent folders avoid the following error:

Changes

Verification

squat commented 2 years ago

@achede22 please sign your commit and then we can merge this :) Hint: git commit amend --signoff

squat commented 2 years ago

@achede22 please sign the DCO and we can merge :)

achede22 commented 2 years ago

Done!, the DCO has been signed.

Please check

On Wed, Mar 30, 2022 at 6:21 AM Lucas Servén Marín @.***> wrote:

@achede22 https://github.com/achede22 please sign the DCO and we can merge :)

— Reply to this email directly, view it on GitHub https://github.com/thanos-io/kube-thanos/pull/268#issuecomment-1082832016, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHDBS2AFB2TC2BBE4MOBRR3VCQMI3ANCNFSM5RSXEAQA . You are receiving this because you were mentioned.Message ID: @.***>

metalmatze commented 2 years ago

Perfect! 👍 Because we embed some files for ease in our README.md and we generate that, could you be so kind and run make README.md to update the README with your changes? Thanks!

achede22 commented 2 years ago

Perfect! +1 Because we embed some files for ease in our README.md and we generate that, could you be so kind and run make README.md to update the README with your changes? Thanks!

done!

achede22 commented 2 years ago

make README.md done! Thanks

On Mon, Apr 4, 2022 at 6:50 AM Matthias Loibl @.***> wrote:

Perfect! 👍 Because we embed some files for ease in our README.md and we generate that, could you be so kind and run make README.md to update the README with your changes? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/thanos-io/kube-thanos/pull/268#issuecomment-1087345556, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHDBS2GRVZUJRAQA2TPGCI3VDK3PPANCNFSM5RSXEAQA . You are receiving this because you were mentioned.Message ID: @.***>

squat commented 2 years ago

Hi @achede22 it looks like one of more of your commits doesn't have the DCO signed. Once you sign we can merge :) it might be easiest if you squash your commits, as then you'll only need to sign once.

achede22 commented 2 years ago

Let me do it again with just one commit, Thanks