thanos-io / kube-thanos

Kubernetes specific configuration for deploying Thanos.
Apache License 2.0
520 stars 177 forks source link

receive: Removing version from label selector so that version updates are working #289

Open pjastrzabek-roche opened 1 year ago

pjastrzabek-roche commented 1 year ago

Removing version from label selector so that version updates are working.

Currently it would throw an error like:

Deployment/thanos/thanos-receive-router dry-run failed, reason: Invalid, error: Deployment.apps "thanos-receive-router" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/component":"thanos-receive-router", "app.kubernetes.io/instance":"thanos-receive", "app.kubernetes.io/name":"thanos-receive", "app.kubernetes.io/version":"v0.29.0"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

Signed-off-by: pjastrzabek-roche 105636104+pjastrzabek-roche@users.noreply.github.com

pjastrzabek-roche commented 1 year ago

what exactly is wrong with that build?