thanos-io / kube-thanos

Kubernetes specific configuration for deploying Thanos.
Apache License 2.0
520 stars 177 forks source link

fix: receive router deployment selector labels #295

Closed dschaaff closed 3 months ago

dschaaff commented 1 year ago

The pod selector labels on the receive router deployment include the version label. Selector labels are immutable and this prevents updating the receive router.

Deployment/monitoring/thanos-receive-router dry-run failed, reason: Invalid, error: Deployment.apps "thanos-receive-router" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/component":"thanos-receive-router", "app.kubernetes.io/instance":"thanos-receive", "app.kubernetes.io/name":"thanos-receive", "app.kubernetes.io/version":"v0.30.2"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

Signed-off-by: Daniel Schaaff daniel@danielschaaff.com

Changes

Verification

michael-burt commented 3 months ago

Hi @philipgough, @douglascamata, @metalmatze

Would it be possible to get this PR reviewed and merged? @dschaaff would you be able to resolve conflicts?

douglascamata commented 3 months ago

@michael-burt out of all the people you pinged, only @metalmatze is a maintainer, but he hasn't been active in the project. The others are just contributors (like @philipgough) or triagers (like me), without merge rights. Please ask for a review in the #thanos-dev channel in the CNCF slack, that's the right place.

douglascamata commented 3 months ago

I can review and approve, but I can't merge.

douglascamata commented 3 months ago

Also, Github is telling me that there are conflicts in this branch that must be solved.

dschaaff commented 3 months ago

I've resolved the conflicts

yeya24 commented 3 months ago

Thanks