thanos-io / kube-thanos

Kubernetes specific configuration for deploying Thanos.
Apache License 2.0
520 stars 177 forks source link

Cannot upgrade thanos-receive-router since the generated manifest include the version in the selector. #317

Open codestation opened 7 months ago

codestation commented 7 months ago

If the thanos version is updated in the jsonnet file and new manifests are generated, those cannot be used to upgrade to a new version as the thanos-receive-router uses the version as one of the labels in the selector. Those labels are inmutable so applying the deployment manifest will fail.

Workaround: delete the thanos-receive-router deployment before upgrading.

Fix: do not include the app.kubernetes.io/version label in the selector matchLabels.