thanos-io / kube-thanos

Kubernetes specific configuration for deploying Thanos.
Apache License 2.0
520 stars 177 forks source link

Remove app.kubernetes.io/version from Router Deployment Selector Labels #321

Closed michael-burt closed 3 months ago

michael-burt commented 3 months ago

I updated the selector labels on the Receive Router deployment so that they exclude the version. This fixes a bug where it wasn't possible to upgrade the router version without deleting the deployment due to immutability of selector labels.

Changes

I have removed the app.kubernetes.io/version label from the Receive Router deployment selector

Verification

I am running this code in my dev environment and it fixes the issue I was experiencing whereby Thanos Receive Router would fail to update when a new version of Thanos is deployed due to immutable selector labels being changed.

yeya24 commented 3 months ago

Do we need to update other deployments as well

michael-burt commented 3 months ago

Do we need to update other deployments as well

This is already configured for the other components: