thanos-io / promql-engine

Multi-threaded PromQL engine implementation based on the Volcano paper.
Apache License 2.0
141 stars 54 forks source link

execution: add timestamp function #361

Closed MichaHoffmann closed 9 months ago

MichaHoffmann commented 9 months ago

This PR implements "timestamp" by pushing it down into the vector scanner. It is communicated via selector hints.

MichaHoffmann commented 9 months ago

Really nice work 👍 Could we add some tests? :)

Ill add some! I did omit them since during implementation the acceptance tests from promql upstream failed and i assumed its already covered but having them explicitly is much better of course!