Closed MichaHoffmann closed 9 months ago
How will this facilitate capturing custom telemetry data that is not applicable to all operators i.e. how we will be able to add telemetry data from inside the operators themselves? My point is that the operators need to be aware of the telemetry implementation. Having a wrapper makes life easier but I think it would be better to only have one way of implementing telemetry.
Yeah this method only allows capturing telemetry that is applicable to all operators like this; is this a dealbreaker?
Maybe we can revert the removal of telemetry embedding and keep this wrapper only for CPU wall time? I think realistically this wrapper can only capture this info
Maybe we can revert the removal of telemetry embedding and keep this wrapper only for CPU wall time? I think realistically this wrapper can only capture this info
Lets close this PR! While working on it i found that subquery telemetry is broken i think though ( the nested options never get the "EnableAnalysis" flag; ill open followup to fix that )
Instead of every operator needing to implement the OperatorTelemetry interface we just wrap and render analysis by piggybacking of Explain. This also has the benefit of reusing Explains node names.
TODO: