search

thanos-io / promql-engine

Multi-threaded PromQL engine implementation based on the Volcano paper.
Apache License 2.0
133 stars 52 forks source link

execution: make subquery respect steps batch #377

Closed MichaHoffmann closed 6 months ago

MichaHoffmann commented 6 months ago

Subquery should return batches of size "opts.StepsBatch" to not break later operators.

MichaHoffmann commented 6 months ago

No major regressions:

RangeQuery/subquery-8                                        350.3m ± ∞ ¹    187.7m ± ∞ ¹   -46.41% (p=0.008 n=5)

and

RangeQuery/subquery-8                                       24.58Mi ± ∞ ¹    30.25Mi ± ∞ ¹   +23.07% (p=0.008 n=5)