thanos-io / promql-engine

Multi-threaded PromQL engine implementation based on the Volcano paper.
Apache License 2.0
133 stars 52 forks source link

plan, execution: make duplicate label check a logical node #401

Closed MichaHoffmann closed 5 months ago

MichaHoffmann commented 5 months ago

No because technically this runs after optimizers! Non-recursive calls in execution.go might get confused though, but they won't because scanners don't get the wrapper! But let's address this problem in followup PR. If we can write execution.go without type switches on parser.Expr other than the top level one we can reason about this much easier!