search

thanos-io / promql-engine

Multi-threaded PromQL engine implementation based on the Volcano paper.
Apache License 2.0
141 stars 54 forks source link

engine: fix range query duplicate label handling #402

Open MichaHoffmann opened 8 months ago

MichaHoffmann commented 8 months ago

Prometheus seems to care about duplicate samples for label only during the same timestamp. Since our operators might return samples for one result in two different series we need to merge them to one result again.

fpetkovski commented 8 months ago

I would recommend that we do the mapping between different series IDs in the dedup checking operator. This way two series with the same ID would get mapped to a single ID and we will not break the operator contract.