search

thanos-io / promql-engine

Multi-threaded PromQL engine implementation based on the Volcano paper.
Apache License 2.0
141 stars 54 forks source link

Adding support for quantile_over_time in subqueries #411

Closed pedro-stanaka closed 6 months ago

pedro-stanaka commented 6 months ago

Summary

Adding support for quantile_over_time in sub-queries.

MichaHoffmann commented 6 months ago

A few nits again, we can do all of those in followup too if you prefer! The change itself is great

MichaHoffmann commented 6 months ago

I have opened https://github.com/thanos-io/promql-engine/pull/415 today too, we could merge this, rebase and call in the subquery operator; wdyt?

pedro-stanaka commented 6 months ago

I have opened #415 today too, we could merge this, rebase and call in the subquery operator; wdyt?

Please take a last look, if you feel there is something left I think we can take the approach you mentioned here. I was in a hurry and did not pay attention to what I was returning during the refactor.