search

thanos-io / promql-engine

Multi-threaded PromQL engine implementation based on the Volcano paper.
Apache License 2.0
131 stars 52 forks source link

Minor fixes to InstantQueryFromPlan #439

Closed fpetkovski closed 3 months ago

fpetkovski commented 3 months ago

The query type for instant queries from an existing plan were set to RangeQuery because we were using the same function as the one used for range queries. This leads to empty results for those queries.

We still need to infer the sort order for the instant query, but this might not be needed since the sort would be done at the root anyway.

We will need better integration tests for this function in the future to prevent regressions.

yeya24 commented 3 months ago

We have the promqlsmith based Fuzz tests for Distributed execution as well. It is probably just skipped during CI. Does it help capture the problem earlier?

MichaHoffmann commented 3 months ago

We have the promqlsmith based Fuzz tests for Distributed execution as well. It is probably just skipped during CI. Does it help capture the problem earlier?

We have to revisit them at some point; right now its not easy to get them to run well without failures

fpetkovski commented 3 months ago

Yeah fuzzing is disabled, but we should try enabling it again. We should also use this method in distributed tests, even though it will require adding another for loop :)