engine,execution: range-vector sub queries with non constant params

thanos-io / promql-engine

Multi-threaded PromQL engine implementation based on the Volcano paper.

Apache License 2.0

131 stars 52 forks source link

engine,execution: range-vector sub queries with non constant params #440

Closed MichaHoffmann closed 3 months ago

MichaHoffmann commented 3 months ago

TODO:

add predict_linear
allow non-constant parameters in subqueries
equate - and + Inf in tests ( its a known failure if we divide by a sum that sums to -0 we return +0 and +inf then )

MichaHoffmann commented 3 months ago

Making the parameter non-constant in matrix_selector is slightly trickier and is deferred to follow-up PR

MichaHoffmann commented 3 months ago

This only solves subqueries correct? We still need to implement these functions for regular matrix selector.

Yeah! This shouldn't be hard I just couldn't decide for a nice interface for scanners since they would need a vector operator in their constructor for the scalar argument