search

thanos-io / promql-engine

Multi-threaded PromQL engine implementation based on the Volcano paper.
Apache License 2.0
141 stars 54 forks source link

misc: bump prometheus to 0.52.0 #455

Closed MichaHoffmann closed 4 months ago

MichaHoffmann commented 4 months ago

For compatibility with prometheus we need to introduce a preprocessor to make scalar arguments in aggregations step invariant. Functions like quantile_over_time are exempt from that so far so we dont need to preprocess them as of now.

MichaHoffmann commented 4 months ago

cc @pedro-stanaka

yeya24 commented 4 months ago

Which upstream commit is it?

For compatibility with prometheus we need to introduce a preprocessor to make scalar arguments in aggregations step invariant

Does it mean this query is not valid anymore? topk(scalar(sum(some_metric)), another_metric)

MichaHoffmann commented 4 months ago

Which upstream commit is it?

For compatibility with prometheus we need to introduce a preprocessor to make scalar arguments in aggregations step invariant

Does it mean this query is not valid anymore? topk(scalar(sum(some_metric)), another_metric)

It's valid but its treated as step invariant I think. As in the parameter value will be the value of the sum at the start of the range.

Edit: likely https://github.com/prometheus/prometheus/pull/13744