Block viewer: New UI extension ideas - Githubissues

thanos-io / thanos

Highly available Prometheus setup with long term storage capabilities. A CNCF Incubating project.

https://thanos.io

Apache License 2.0

12.99k stars 2.08k forks source link

Block viewer: New UI extension ideas #3112

Open bwplotka opened 4 years ago

bwplotka commented 4 years ago

It looks amazing (zoom out view 75%):

And works well, but some minor nits that come to my mind if someone has spare cycles:

[x] It takes to much vertical space, I think I would reduce vertical whitespace to a minimum.
[ ] It would be amazing to just group them by all external labels (no config needed?)
[ ] Show different statuses as different colors / details on global view
[ ] Vertical lines for some grid like on old UI?
[ ] Stats on top: when was the last refresh, how many blocks overall, how many blocks in each group (?)
[ ] Search input that will allow to group them on certain labels?
[ ] It would be amazing if we can someday add extra stats like (for loaded page):
- What blocks are currently being compacted, downsampled! (:
[ ] Using different colors is ok ;p (same as we use for coloring graphs)

cc @prmsrswt

kunal-kushwaha commented 4 years ago

I'd like to take this 🙌

daksh-sagar commented 4 years ago

@bwplotka are we talking about the vertical whitespace that is present between the blocks like in the first row in the above image?

bwplotka commented 3 years ago

Are you talking about first action item? We would like to reduce it to a minimum. First row blocks show some overlapping blocks that's why they are close. We need to make sure it's closer but not too much to show that those are for different external labels (:

daksh-sagar commented 3 years ago

I've made some changes, this is what it looks like right now. What do you think @bwplotka ? blocks

bwplotka commented 3 years ago

It looks better! :muscle: Looking forward for a PR (:

daksh-sagar commented 3 years ago

@prmsrswt Need help regarding 5th action item: "display stats on top". How should it be displayed (visually) ?

daksh-sagar commented 3 years ago

I'm working on the 5th action item. This is how I'm displaying refreshed at, total blocks, and blocks in each group. Can I have your feedback please. @prmsrswt @bwplotka stats

aribalam commented 3 years ago

@daksh-sagar Just out of curiosity, How do I access the Block Viewer using the Thanos Query UI (as given in the picture above). I was unable to access it using a dockerized setup. I was only able to use it through the Bucket Web and the Compactor component. @prmsrswt Is there anything I am missing out?

daksh-sagar commented 3 years ago

@aribalam You need to uncomment the bucket-web in the docker-compose file and then change the proxy in the package.json to port 8080. Let me know if you need to know anything else.

aribalam commented 3 years ago

@daksh-sagar The commenting part is alright but in my opinion, I don't think it's necessary to change the proxy as it is handled accordingly. You just have to visit the dedicated port (i.e localhost:8080/blocks) instead of localhost:10902/blocks, which is dedicated to the Query component. I am just wondering if it's alright to access the Block Viewer through the Query UI. @prmsrswt Any thoughts on this?

daksh-sagar commented 3 years ago

@aribalam I thought you were accessing the react-app through the thanos repo on your local machine.

Oghenebrume50 commented 3 years ago

I also have problems accessing the block viewer I should try @aribalam method

PS: tried that and no need to change the proxy in package.json actually

stale[bot] commented 3 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

kunal-kushwaha commented 3 years ago

In progress!

stale[bot] commented 3 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

kunal-kushwaha commented 3 years ago

Still valid

kakkoyun commented 3 years ago

Help wanted 🤗

stale[bot] commented 3 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

flyingcanopy commented 3 years ago

Hi, this is part of the Linux Foundation mentorship. Can I please work on this? Thanos: Enhanced Block Viewer UI

EmperorYP7 commented 3 years ago

Hello everyone! 🙋🏻 I'd like to work on this. I did submit my application for the same on the LFX Mentorship portal. Looking forward to learning a lot from the community! 🙌🏻

NBNARADHYA commented 3 years ago

Hey guys 🙋‍♂️, I'm Nikhil.

I saw this project on the LFX Mentorship site and it needs a mentee for the project. I have applied for this project on the LFX Mentorship website and I would love to work on this ! 😃

stale[bot] commented 3 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] commented 3 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] commented 2 years ago

Closing for now as promised, let us know if you need this to be reopened! 🤗

stale[bot] commented 2 years ago

Closing for now as promised, let us know if you need this to be reopened! 🤗

yeya24 commented 2 years ago

Still valid

stale[bot] commented 2 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] commented 2 years ago

Closing for now as promised, let us know if you need this to be reopened! 🤗

stale[bot] commented 2 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.