thanos-io / thanos

Highly available Prometheus setup with long term storage capabilities. A CNCF Incubating project.
https://thanos.io
Apache License 2.0
13.11k stars 2.1k forks source link

Block Viewer: Show some additional stats #3219

Open onprem opened 4 years ago

onprem commented 4 years ago

We can show some more information in the Block Viewer:

aribalam commented 4 years ago

@prmsrswt How would you like to display block statistics for each group? I was thinking of displaying it in the right sidebar similar to that of each block.

onprem commented 4 years ago

Hmm, that can work. Currently, I don't have a design in my mind, it'd be great if you can figure out something.

daksh-sagar commented 4 years ago

@aribalam I've opened a PR that takes care of the first 3 points so you might want to skip them. cc: @prmsrswt

stale[bot] commented 3 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] commented 3 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

yeya24 commented 3 years ago

Still valid.

ruddi10 commented 3 years ago

@kakkoyun @prmsrswt Can I take up this issue?

onprem commented 3 years ago

@ruddi10 sure, there's some on-going work around this issue so just keep those in mind.

ruddi10 commented 3 years ago

@prmsrswt There are no linked pull requests with this issue. So if you can please tell me what all is completed

onprem commented 3 years ago

There's this PR which handles quite a few of them: https://github.com/thanos-io/thanos/pull/3467

stale[bot] commented 3 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

kakkoyun commented 3 years ago

Still valid.

stale[bot] commented 3 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] commented 3 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] commented 2 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] commented 2 years ago

Closing for now as promised, let us know if you need this to be reopened! 🤗

stale[bot] commented 2 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

adithyaakrishna commented 2 years ago

@GiedriusS Can I work on this? 👀

I guess there's a PR https://github.com/thanos-io/thanos/pull/3467 which can be used as the base 😶

GiedriusS commented 2 years ago

Yep! Feel free to ask any questions if you have any.

sagnik3788 commented 11 months ago

@GiedriusS has this issue been resolved? If not, may I take up this task?

yeya24 commented 11 months ago

@sagnik3788 Just go for it as I believe no one is working on this task