search

thanos-io / thanos

Highly available Prometheus setup with long term storage capabilities. A CNCF Incubating project.
https://thanos.io
Apache License 2.0
12.98k stars 2.08k forks source link

CI: CircleCI `test` runs take too long #4862

Open matej-g opened 2 years ago

matej-g commented 2 years ago

As I was recently looking into insights on Thanos CircleCI, I discovered that the tests take far too long in comparison with local runs - for example, the median for the last 7 days is ~30 minutes and the 95th percentile is whooping 1 hour. This is incomparable to the tests timed locally which run (with uncached test results) for roughly 2 and a half minutes.

My suspicion is that when bingo installs the dependencies (prometheus, alertmanager, minio), it is always downloading the required packages again (whereas locally this is done only the first time tests run). This is adding significant overhead; if possible, we should find a way to cache the dependencies between CI runs.

stale[bot] commented 2 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

matej-g commented 2 years ago

Still needed 😢

stale[bot] commented 2 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

stale[bot] commented 2 years ago

Closing for now as promised, let us know if you need this to be reopened! 🤗

stale[bot] commented 2 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.