search

thanos-io / thanos

Highly available Prometheus setup with long term storage capabilities. A CNCF Incubating project.
https://thanos.io
Apache License 2.0
12.75k stars 2.04k forks source link

Unable to configure Azure storage with UserIdentity #5232

Open anoop2503 opened 2 years ago

anoop2503 commented 2 years ago

Thanos Version: v0.23.1

Object Storage Provider: AZURE

What happened: I have deployed prometheus in Kubernetes and trying to configure object storage as Azure blob storage. To avoid using storage_account_key in the storage configuration, I am using aadpodidbinding in prometheus statefulset to use Azure blob storage. However, when I am running the prometheus, I am getting following error for thanos-sidecar container.

level=error ts=2022-03-09T10:43:39.627694164Z caller=main.go:131 err="invalid Azure storage configuration, no Azure storage_account_key specified while storage_account is present in config file; both should be present\ngithub.com/thanos-io/thanos/pkg/objstore/azure.(*Config).validate\n\t/home/circleci/project/pkg/objstore/azure/azure.go:136\ngithub.com/thanos-io/thanos/pkg/objstore/azure.NewBucket\n\t/home/circleci/project/pkg/objstore/azure/azure.go:172\ngithub.com/thanos-io/thanos/pkg/objstore/client.NewBucket\n\t/home/circleci/project/pkg/objstore/client/factory.go:67\nmain.runSidecar\n\t/home/circleci/project/cmd/thanos/sidecar.go:272\nmain.registerSidecar.func1\n\t/home/circleci/project/cmd/thanos/sidecar.go:72\nmain.main\n\t/home/circleci/project/cmd/thanos/main.go:129\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:225\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371\ncreate AZURE client\ngithub.com/thanos-io/thanos/pkg/objstore/client.NewBucket\n\t/home/circleci/project/pkg/objstore/client/factory.go:82\nmain.runSidecar\n\t/home/circleci/project/cmd/thanos/sidecar.go:272\nmain.registerSidecar.func1\n\t/home/circleci/project/cmd/thanos/sidecar.go:72\nmain.main\n\t/home/circleci/project/cmd/thanos/main.go:129\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:225\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371\npreparing sidecar command failed\nmain.main\n\t/home/circleci/project/cmd/thanos/main.go:131\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:225\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371"

My current object storage configuration is given below:

type: AZURE
config:
  storage_account: "thanosprom"
  container: "thanos"
  max_retries: 0

What you expected to happen:

Thanos sidecar should run without any failure.

phillebaba commented 2 years ago

Have a try with the latest version of Thanos. There have been changes to expand support for Azure authentication. https://github.com/thanos-io/thanos/pull/4636

stale[bot] commented 2 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.