thanos-io / thanos

Highly available Prometheus setup with long term storage capabilities. A CNCF Incubating project.
https://thanos.io
Apache License 2.0
13.09k stars 2.1k forks source link

Federate the api/v1/status/tsdb endpoint from Prometheus #5395

Open fpetkovski opened 2 years ago

fpetkovski commented 2 years ago

Is your proposal related to a problem?

It would be great if Thanos Query could federate the api/v1/status/tsdb endpoint from Prometheus instances. This will allow users to analyze cardinality on the fly.

Describe the solution you'd like

Thanos Query could fanout to Prometheus sidecars and return a federated result from all endpoints.

Describe alternatives you've considered

We currently run https://github.com/thought-machine/prometheus-cardinality-exporter, but this requires ingesting metrics which further increases cardinality :)

bwplotka commented 2 years ago

Yes, I would see that as a potential gRPC API for our endpoints that Querier could merge.

We currently run https://github.com/thought-machine/prometheus-cardinality-exporter, but this requires ingesting metrics which further increases cardinality :)

Not if you use separate meta-monitoring which is a best practice (:

I think the main questions is to nail down exact API - what we want to people use it for and if a nice metric exposed by the receiver to meta-monitoring cannot fulfil the same purpose.

Potential Why nots

stale[bot] commented 2 years ago

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

yeya24 commented 2 years ago

@fpetkovski Any next step for this issue?

fpetkovski commented 2 years ago

Unfortunately I don't have capacity to work on this right now, I am primarily focused on the new engine. If no one has stepped up to tackle this, maybe we can close it for now?

DanielCastronovo commented 7 months ago

Hello, it could be nice to have this feature :)