search

thanos-io / thanos

Highly available Prometheus setup with long term storage capabilities. A CNCF Incubating project.
https://thanos.io
Apache License 2.0
12.76k stars 2.04k forks source link

TSDB status API served using remote write port #6239

Open yeya24 opened 1 year ago

yeya24 commented 1 year ago

What happened:

Thanos Receiver serves TSDB status API /api/v1/status/tsdb using its remote write address, by default it is remote-write.address.

What you expected to happen:

I expect that HTTP API is served using Receiver's http address specified with --http-address flag, not the port for remote write.

Actually it is not very clear to me why we have a dedicated remote-write.address address for remote write only. Ideally we should consolidate it with the other http server.

fpetkovski commented 1 year ago

Good catch. I agree we should have only one http server and use the same port for everything.

yeya24 commented 1 year ago

Thanks for the quick reply. This could be a breaking change and I am not sure what kind of approach we should take. I guess we would still keep the remote write address, but we can start serving the TSDB status API in both addresses?

fpetkovski commented 1 year ago

Agree, this will be a pretty big change, so we need to support both servers/ports at the same time for at least a few releases. We can emit a deprecation warning in the logs in addition to adding a changelog entry.