search

thanos-io / thanos

Highly available Prometheus setup with long term storage capabilities. A CNCF Incubating project.
https://thanos.io
Apache License 2.0
12.99k stars 2.08k forks source link

bucketweb: attempting to view overlapping blocks results in error page #7216

Open Nashluffy opened 6 months ago

Nashluffy commented 6 months ago

Thanos, Prometheus and Golang version used:

$ thanos --version
thanos, version 0.34.1 (branch: HEAD, revision: 4cf1559998bf6d8db3f9ca0fde2a00d217d4e23e)
  build user:       root@61db75277a55
  build date:       20240219-17:13:48
  go version:       go1.21.7
  platform:         linux/amd64
  tags:             netgo

Object Storage Provider: GCS

What happened: Attempting to view overlapping blocks (/blocks?find-overlapping=1) results in the error page being displayed

What you expected to happen: I can view overlapping blocks in the bucket

How to reproduce it (as minimally and precisely as possible):

  1. Open bucket web UI
  2. Click 'Enable finding overlapping blocks'

Full logs to relevant components:

image
Logs

``` $ k logs -n longterm-thanos-bucketweb-8496d98b97-d7j46 | tail -n10 ts=2024-03-18T07:45:49.695783837Z caller=fetcher.go:557 level=info component=block.BaseFetcher msg="successfully synchronized block metadata" duration=1.890377879s duration_ms=1890 cached=5550 returned=5550 partial=0 ts=2024-03-18T08:15:49.495959404Z caller=fetcher.go:557 level=info component=block.BaseFetcher msg="successfully synchronized block metadata" duration=1.690519043s duration_ms=1690 cached=5550 returned=5550 partial=0 ts=2024-03-18T08:45:49.794292528Z caller=fetcher.go:557 level=info component=block.BaseFetcher msg="successfully synchronized block metadata" duration=1.988511031s duration_ms=1988 cached=5547 returned=5547 partial=0 ts=2024-03-18T09:15:49.693989505Z caller=fetcher.go:557 level=info component=block.BaseFetcher msg="successfully synchronized block metadata" duration=1.887816599s duration_ms=1887 cached=5547 returned=5547 partial=0 ts=2024-03-18T09:45:49.991778911Z caller=fetcher.go:557 level=info component=block.BaseFetcher msg="successfully synchronized block metadata" duration=2.18601158s duration_ms=2186 cached=5544 returned=5544 partial=0 ts=2024-03-18T10:15:49.597049375Z caller=fetcher.go:557 level=info component=block.BaseFetcher msg="successfully synchronized block metadata" duration=1.790654523s duration_ms=1790 cached=5544 returned=5544 partial=0 ```

Anything else we need to know:

outofrange commented 6 months ago

I'm getting the same error - I think I've never seen this working ;)

I created a PR which fixed it for me, but I was assuming that it's related to cases where there are no overlapping blocks found. Do you suspect that you have any in your bucket?

calestyo commented 2 months ago

Seems like a duplicate of #5359.