search

thanos-io / thanos

Highly available Prometheus setup with long term storage capabilities. A CNCF Incubating project.
https://thanos.io
Apache License 2.0
12.93k stars 2.08k forks source link

Support for encryption in transit for Memcached #7270

Open DonovanSoftly opened 5 months ago

DonovanSoftly commented 5 months ago

Is your proposal related to a problem?

We have activated the encryption in transit on our Amazon ElastiCache for Memcached. Afterwards, Thanos failed to connect to memcached like the error below.

ts=2024-04-09T02:47:04.90578891Z caller=memcached.go:250 level=error msg="failed to put to memcached" name= err="read tcp 10.170.59.248:58922->10.170.49.42:11211: read: connection reset by peer"

Describe the solution you'd like

Support for encryption in transit for Memcached

jeroen-nijssen commented 5 months ago

We are looking into some cost saving (besides the security aspect) and it seems that AWS ElastiCache Memcached Serverless requires the connection to encrypted.

So it would be great if this feature is pushed trough.. !

yeya24 commented 5 months ago

In our Thanos fork, we added memcached TLS support for the exact the same reason. We will try to contribute our changes back when we get the chance.

jeroen-nijssen commented 3 months ago

In our Thanos fork, we added memcached TLS support for the exact the same reason. We will try to contribute our changes back when we get the chance.

@yeya24, did you find a change to contribute your changes?

BlackDex commented 2 weeks ago

@yeya24, any change you can create a PR for this?