Query: Fixing extended functions in distributed querier

thanos-io / thanos

Highly available Prometheus setup with long term storage capabilities. A CNCF Incubating project.

https://thanos.io

Apache License 2.0

12.67k stars 2.03k forks source link

Query: Fixing extended functions in distributed querier #7331

Closed pedro-stanaka closed 3 weeks ago

pedro-stanaka commented 4 weeks ago

[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Adding repro case for broken query with distributed engine
Fixing problem with distributed queries and xfunctions
Adding support for extended functions in tenancy enforcement
Moving custom parser to new package

Verification

Added new acceptance tests and tested locally with two queriers.

MichaHoffmann commented 4 weeks ago

LGTM, can you separate the prometheus import from stdlib imports though please?

pedro-stanaka commented 4 weeks ago

LGTM, can you separate the prometheus import from stdlib imports though please?

@MichaHoffmann can you recheck?

pedro-stanaka commented 4 weeks ago

Should we forbid using parser.ParseExpr directly through faillint? What about other places where parser.ParseExpr is used? 🤔

I have a follow up PR where I will clean up all other places where we use parser.ParserExpr did not want to include on this one because I will touch more than 30 files. I can also create this fail lint rule if it is the case.