search

thanpolas / grunt-closure-tools

Google Closure Tools for grunt
MIT License
95 stars 22 forks source link

fails if source files not changed #28

Closed EggDice closed 11 years ago

EggDice commented 11 years ago

If I use checkModified: true in the config, it fails grunt if source files are not changed. I think it should not like compass does.

thanpolas commented 11 years ago

@EggDice can you provide a bit more information?

Isn't that the expected behavior when no files are changed? What do you need to happen?

ping @izb

EggDice commented 11 years ago

in grunt-contrib-compass or in compass generally if there is no file change the task is succeed but it does nothing, this is a good thing because if you have other tasks after it those will run. Here if there is no file change the task is failing and the tasks after closure are not running if you are not use the --force flag. I hope I made it clearer. Sorry about my English! :)

thanpolas commented 11 years ago

Yes, that makes sense, that's how it should be

thanpolas commented 11 years ago

Thank you @EggDice, patches have been merged, i will release a new version when there are more changes queued up, unless it is an urgent matter for you

EggDice commented 11 years ago

If it not a big problem, it would really nice if you release, we would use it! Thanks!

thanpolas commented 11 years ago

ok v0.8.2 is now on npm :)