#45 'create_source_map' support for src-dest mappings with specified des...

thanpolas / grunt-closure-tools

Google Closure Tools for grunt

MIT License

95 stars 22 forks source link

#45 'create_source_map' support for src-dest mappings with specified des... #46

Closed fhurta closed 10 years ago

fhurta commented 10 years ago

Added the possibility to create dest-filename-based source map file for file mappings where the dest is specified. Regarding the tests - not sure how to extend the current test case. Please review and add the test if needed.

thanpolas commented 10 years ago

You need to trigger the mechanism only when Grunt's Source-Destination Mappings have been used.

The only place to know this has happened is at the point i showed you in #45

Every file under the /lib folder is decoupled from Grunt logic and thus nothing there should be touched...

fhurta commented 10 years ago

oh, I see it now (I did bad assumption the dest in libCompiler.js is defined only for mapping entries) I will fix it and submit another PR

thanpolas commented 10 years ago

v0.8.5 is now on NPM :)

Thank you @fhurta !