search

thanpolas / grunt-closure-tools

Google Closure Tools for grunt
MIT License
95 stars 22 forks source link

Include compiler.jar package info on README #54

Closed zgmnkv closed 10 years ago

zgmnkv commented 10 years ago

Hi, It would be nice if closure compiler jar file will be included into this plugin, so that the end-user won't have to download it manually, place it somewhere on a file system and configure path to it. It will help to make projects more portable and easy to install on build servers. Thanks

thanpolas commented 10 years ago

I've been weighing this matter a long time now... my main concern is package size. This package (grunt-closure-tools) is around 2.8mb when installed. i maintain a compiled jar file as a node project, the size of this package when installed is around 32mb.

So you can see with one simple move we're blowing the package's size 10x...

I'm really concerned with this as every installation of the package will take that much longer to finish....

zgmnkv commented 10 years ago

But manual download and installation of jar file will be much longer than automated. Maybe we can download jar not with package installation but lazily when grunt task runs. We can store jar file globally somewhere in hidden directory in user home, if you concerned about downloading file for each project on same machine. At last we can make it an optional feature, so that user can always download it manually and specify path to downloaded jar.

thanpolas commented 10 years ago

You can always include the superstartup-closure-compiler package in your project and use it... I think that's the best solution.

zgmnkv commented 10 years ago

Ok, this solution suits for me, thanks! Maybe it will be useful to mention it in readme. 03.02.2014 15:58 ÐÏÌØÚÏ×ÁÔÅÌØ "Thanasis Polychronakis" < notifications@github.com> ÎÁÐÉÓÁÌ:

You can always include the superstartup-closure-compiler package in your project and use it... I think that's the best solution.

Reply to this email directly or view it on GitHubhttps://github.com/closureplease/grunt-closure-tools/issues/54#issuecomment-33946570 .

thanpolas commented 10 years ago

yup, agree, changing the title of this issue