search

thanpolas / grunt-closure-tools

Google Closure Tools for grunt
MIT License
95 stars 22 forks source link

Closure Builder is deprecated #65

Closed bwasty closed 7 years ago

bwasty commented 10 years ago

I'm getting this message now during the closureBuilder task:

.../closure-library/closure/bin/build/closurebuilder.py: Closure Compiler now natively understands and orders Closure dependencies and is prefererred over using this script for performing JavaScript compilation. 

Please migrate your codebase. 

See: https://code.google.com/p/closure-compiler/wiki/ManageClosureDependencies

I haven't looked at all the details, so I don't know how it affects this plugin, just wanted to let you know.

thanpolas commented 10 years ago

thanks @bwasty, hope someone takes up on that, too busy atm

bwasty commented 9 years ago

Update: no changes are necessary in the plugin - just some small tweeks to the config (remove namespaces, add compiler options closure_entry_point and only_closure_dependencies), replace closureBuilder by closureCompiler and it works as before.

thanpolas commented 9 years ago

@bwasty would you care for a PR?

bpicolo commented 9 years ago

For reference, looks mostly that actually compiling via closurebuilder is deprecated, rather than using it to list potential dependencies.

thanpolas commented 7 years ago

closing due to inactivity, feel free to re-open if the issue persists.