thaolt / qscite

Automatically exported from code.google.com/p/qscite
GNU General Public License v2.0
0 stars 0 forks source link

Bad connection in line ending UI #22

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The new menu items for EOL mode are connected directly to whatever document
happens to be open at the time. As soon as that document is closed, they
cease to work.
We need to add slots to MainWindow to route the requested action to the
right document, similarly to what we do for all of the actions on the Edit
menu.
The same bug has been introduced in every new menu item that has been
added. One would think some lessons would have been learned by now.

Original issue reported on code.google.com by bfrobin...@gmail.com on 10 Mar 2008 at 5:10

GoogleCodeExporter commented 8 years ago
Well, here's the deal...

I've been implementing them in such a way that when the document is changed, the
signals that are connected to that document are disconnected and then 
re-connected to
the next document to be displayed.  If you've been re-implementing this in a 
better
way, I just haven't noticed.  I usually test my implementations to make sure 
they
work in at least the most common of usage scenarios, so I'm not aware of any of 
these
bugs before committing to SVN.

I'll see if I can't fix it though. :)

Original comment by jpsut...@gmail.com on 10 Mar 2008 at 5:18

GoogleCodeExporter commented 8 years ago
Some things are still failing to connect when I create a new document in an 
empty
window. The proxy-slot method that I've been using is less state to keep 
consistent,
so it's easier to get right.

Original comment by bfrobin...@gmail.com on 10 Mar 2008 at 6:19

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Should be fixed by now.

Original comment by bfrobin...@gmail.com on 11 Mar 2008 at 12:57