thardy / generator-ngbp

Yeoman generator based on the ngBoilerplate kickstarter, a best-practice boilerplate for any scale Angular project built on a highly modular, folder-by-feature structure.
100 stars 23 forks source link

ngbp differences #8

Closed so0k closed 10 years ago

so0k commented 10 years ago

I'm rather new to ngBoilerplate and decided to use this generator to dive into this, however I noticed some differences between the generator current gruntFile and the ngbp gruntFile.

I have some questions:

In my project it was decided to use Foundation5, so I replaced bootstrap&angular-bootstrap and added the grunt-sass (libsass) plugin and related tasks.

If I have the opportunity to study more about generators, offering foundation/libsass as alternative to bootstrap/LESS might be something I can try to contribute.

perhaps it might be useful for others if I can contribute the gruntFile as follows?

looking forward to comments/advice

so0k commented 10 years ago

I've published the project where I've replaced Bootstrap(LESS) for Foundation(SASS) and which has an updated gruntFile with libsass compilation here

thardy commented 10 years ago

I'll take a look. I think ngbp changed after I launched this generator. I'll figure out what has changed and make them in here.

scpeterson commented 10 years ago

When do you think that the generator will be updated with the latest ngbp?

thardy commented 10 years ago

Ok, I finally added most of the latest ngbp changes to generator-ngbp. If I missed anything valuable to you, please let me know.

I also added ng-annotate support, and it's working a ton better than ng-min ever did. Namely, it's faster and it handles enclosures just fine.

You are welcome to add the changelog and time-grunt tasks. As to an express replacement, I've been looking at Hapi. I'm not ready to make that change yet though. I don't want to change a lot of the building blocks out from under everyone without due consideration. I've also been looking at Gulp for a Grunt replacement, but I figure that needs time to gain more momentum as well.

As to a grunt-wiredep task, if you have a clean, well-tested improvement, I'd love to look at it. Beyond that, I think grunt is way too complicated and that's why I think Gulp will probably overtake it within the next couple years. I'm willing to wait for a wholesale replacement personally.

so0k commented 10 years ago

great, thanks!