variation PRose3DFunc: Method uses the same code for two branches

[smack42]

Detected by FindBugs in class JWildfire/src/org/jwildfire/create/tina/variation/PRose3DFunc. The fix would be trivial, just remove the redundant code.

However, I think this can be a real error and that the if/else paths should have contained different code. Please verify.

    else // this is the option when optDir > 0.0
    {
      if (posNeg < 0)
      {
        pVarTP.x += pAmount * 0.5 * (length * cos(numPetals * th + constant)) * cth;
        pVarTP.y += pAmount * 0.5 * (length * cos(numPetals * th + constant)) * sth;
        pVarTP.z += pAmount * 0.5 * ((scaleZ1 * waggle + sqr(rad * 0.5) * sin(wig) * wigScale) + (this.dist));

      }
      else
      {
        pVarTP.x += pAmount * 0.5 * (length * cos(numPetals * th + constant)) * cth;
        pVarTP.y += pAmount * 0.5 * (length * cos(numPetals * th + constant)) * sth;
        pVarTP.z += pAmount * 0.5 * ((scaleZ1 * waggle + sqr(rad * 0.5) * sin(wig) * wigScale) + (this.dist));
      }
    }
  }

[thargor6]

Interesting, but I did not create this variation, so I'm not sure what was intended. I think, it is better to remove it

[smack42]

Agreed, lets remove it. The original C-code contains the same code duplication. http://aporev.deviantart.com/gallery/#/d2blmhg