thartbm / PyVMEC

A Python-based GUI to create and run visuo-motor experiments.
GNU General Public License v3.0
1 stars 3 forks source link

rotated error-clamp trials end on distance criteria #91

Closed thartbm closed 5 years ago

thartbm commented 5 years ago

Problem: when error-clamped trials are rotated, the trials can't be completed because you can never reach the target with your rotated cursor.

Perhaps the criterion for error-clamp trials to end should not be to get the cursor on the target, but to get the cursor to the distance the target is at. Or alternatively, do the criterion on a zero-clamped cursor, that is calculated before the clamped cursor is rotated for the display? Not sure what would be the best solution.

juliusjgm12 commented 5 years ago

Oh i thought I tested this already, I guess not. The code is already there for detecting the cursor at a distance the target is at, but i suppose i forgot to implement it for the error-clamped terminal feedback case.

juliusjgm12 commented 5 years ago

Nevermind, I misread and thought you meant it wasn't working for error-clamped terminal feedback trials. I understand. I think i'll make the criterion the former you detailed.