tharyckgusmao / Skill-Share-Crawler---DL

Download Videos Skill Share per ID or per Class
125 stars 34 forks source link

Some courses stop downloading unexpectedly on Windows #4

Closed ipkpjersi closed 6 years ago

ipkpjersi commented 6 years ago

Hello,

I love this program but I do have an issue with it. I think that you should check for invalid characters on Windows (for example, : and " and ?) and then rename them to something else, or simply remove them from the output file altogether. When there is a course that has a file with an invalid name, the entire program crashes and the course cannot be downloaded at all.

Thank you.

tharyckgusmao commented 6 years ago

Hello Friend. I solved this escape caracther problem by replacing the entire replace for my regex replace (/ [^ a-zA-Z0-9] / g, ""), can you send me an id that is giving error? so that I can vindicate the error. Thank you

ipkpjersi commented 6 years ago

Oh, I didn't see that you committed a fix for this issue 13 hours ago - it may actually be fixed after all. I will test it and report back and/or close the issue if it is fixed.

ipkpjersi commented 6 years ago

Sorry for the double post, but I do have an error, not sure if it is related to the naming of files on Windows, though:

I did restart the download and it did complete successfully that time.

tharyckgusmao commented 6 years ago

This error can come to happen even though I am not treating exceptions for it. What happens and that some positions of the json do not exist can occur from the platform have another standard for this video in question because I download the video in high quality and this feature may not exist for some videos.

Inform me please id so I can evaluate and think about a deal. Thanks

ipkpjersi commented 6 years ago

Hello,

One of the videos that does this is: 57220732 and another that does it a LOT is: 1654744071

Thanks.

tharyckgusmao commented 6 years ago

Did you try to download again and right? There may have been some interference with a skillshare api.

For me it was 100% top-notch.

image

ipkpjersi commented 6 years ago

That one worked mostly fine but this one failed a lot: 1654744071

tharyckgusmao commented 6 years ago

Everything very strange, I need to separate a day to carry out a thorough debug, for me it did not present any flaw.

image